The following document contains the results of FindBugs Report
FindBugs Version is 1.2.0
Threshold is Exp
Effort is Max
Classes | Bugs | Errors | Missing Classes |
---|---|---|---|
182 | 59 | 0 | 0 |
Bug | Category | Details | Line |
---|---|---|---|
edu.drexel.cms.actions.AddConferenceAction.getEditorName() may expose internal representation by returning AddConferenceAction._editorName | MALICIOUS_CODE | EI_EXPOSE_REP | 135 |
edu.drexel.cms.actions.AddConferenceAction.setEditorName(String[]) may expose internal representation by storing an externally mutable object into AddConferenceAction._editorName | MALICIOUS_CODE | EI_EXPOSE_REP2 | 139 |
Class edu.drexel.cms.actions.AddConferenceAction defines non-transient non-serializable instance field _request | BAD_PRACTICE | SE_BAD_FIELD | Not available |
Bug | Category | Details | Line |
---|---|---|---|
Class edu.drexel.cms.actions.AddPaperAction defines non-transient non-serializable instance field _request | BAD_PRACTICE | SE_BAD_FIELD | Not available |
Bug | Category | Details | Line |
---|---|---|---|
Class edu.drexel.cms.actions.AddReviewAction defines non-transient non-serializable instance field _request | BAD_PRACTICE | SE_BAD_FIELD | Not available |
Bug | Category | Details | Line |
---|---|---|---|
edu.drexel.cms.actions.AssignEditorAction.getEditorName() may expose internal representation by returning AssignEditorAction._editorName | MALICIOUS_CODE | EI_EXPOSE_REP | 65 |
edu.drexel.cms.actions.AssignEditorAction.setEditorName(String[]) may expose internal representation by storing an externally mutable object into AssignEditorAction._editorName | MALICIOUS_CODE | EI_EXPOSE_REP2 | 69 |
Class edu.drexel.cms.actions.AssignEditorAction defines non-transient non-serializable instance field _request | BAD_PRACTICE | SE_BAD_FIELD | Not available |
Bug | Category | Details | Line |
---|---|---|---|
edu.drexel.cms.actions.AssignReviewerAction.getReviewerName() may expose internal representation by returning AssignReviewerAction._reviewerName | MALICIOUS_CODE | EI_EXPOSE_REP | 62 |
edu.drexel.cms.actions.AssignReviewerAction.setReviewerName(String[]) may expose internal representation by storing an externally mutable object into AssignReviewerAction._reviewerName | MALICIOUS_CODE | EI_EXPOSE_REP2 | 66 |
Class edu.drexel.cms.actions.AssignReviewerAction defines non-transient non-serializable instance field _request | BAD_PRACTICE | SE_BAD_FIELD | Not available |
Bug | Category | Details | Line |
---|---|---|---|
Class edu.drexel.cms.actions.ConferenceDetailAction defines non-transient non-serializable instance field _request | BAD_PRACTICE | SE_BAD_FIELD | Not available |
Bug | Category | Details | Line |
---|---|---|---|
Exception is caught when Exception is not thrown in edu.drexel.cms.actions.LoginAction.execute() | STYLE | REC_CATCH_EXCEPTION | 34 |
Class edu.drexel.cms.actions.LoginAction defines non-transient non-serializable instance field _request | BAD_PRACTICE | SE_BAD_FIELD | Not available |
Bug | Category | Details | Line |
---|---|---|---|
Class edu.drexel.cms.actions.LogoutAction defines non-transient non-serializable instance field _request | BAD_PRACTICE | SE_BAD_FIELD | Not available |
Bug | Category | Details | Line |
---|---|---|---|
Class edu.drexel.cms.actions.NewUserRegistrationAction defines non-transient non-serializable instance field _request | BAD_PRACTICE | SE_BAD_FIELD | Not available |
Bug | Category | Details | Line |
---|---|---|---|
Class edu.drexel.cms.actions.PaperDetailAction defines non-transient non-serializable instance field _request | BAD_PRACTICE | SE_BAD_FIELD | Not available |
Bug | Category | Details | Line |
---|---|---|---|
Class edu.drexel.cms.actions.ReleaseReviewAction defines non-transient non-serializable instance field _request | BAD_PRACTICE | SE_BAD_FIELD | Not available |
Bug | Category | Details | Line |
---|---|---|---|
Class edu.drexel.cms.actions.ReviewDetailAction defines non-transient non-serializable instance field _request | BAD_PRACTICE | SE_BAD_FIELD | Not available |
Bug | Category | Details | Line |
---|---|---|---|
Class edu.drexel.cms.actions.SearchConferencesAction defines non-transient non-serializable instance field _request | BAD_PRACTICE | SE_BAD_FIELD | Not available |
Bug | Category | Details | Line |
---|---|---|---|
Class edu.drexel.cms.actions.SearchPapersAction defines non-transient non-serializable instance field _request | BAD_PRACTICE | SE_BAD_FIELD | Not available |
Bug | Category | Details | Line |
---|---|---|---|
Class edu.drexel.cms.actions.SearchReviewsAction defines non-transient non-serializable instance field _request | BAD_PRACTICE | SE_BAD_FIELD | Not available |
Bug | Category | Details | Line |
---|---|---|---|
Exception is caught when Exception is not thrown in edu.drexel.cms.interceptors.ConferencePageInterceptor.intercept(ActionInvocation) | STYLE | REC_CATCH_EXCEPTION | 51 |
Bug | Category | Details | Line |
---|---|---|---|
Exception is caught when Exception is not thrown in edu.drexel.cms.interceptors.HomePageInterceptor.intercept(ActionInvocation) | STYLE | REC_CATCH_EXCEPTION | 40 |
Bug | Category | Details | Line |
---|---|---|---|
Exception is caught when Exception is not thrown in edu.drexel.cms.interceptors.PaperPageInterceptor.intercept(ActionInvocation) | STYLE | REC_CATCH_EXCEPTION | 49 |
Bug | Category | Details | Line |
---|---|---|---|
Exception is caught when Exception is not thrown in edu.drexel.cms.interceptors.ReviewPageInterceptor.intercept(ActionInvocation) | STYLE | REC_CATCH_EXCEPTION | 48 |
Bug | Category | Details | Line |
---|---|---|---|
edu.drexel.cms.service.service.CmsService.FAILURE isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 39 |
edu.drexel.cms.service.service.CmsService.SUCCESS isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 37 |
Bug | Category | Details | Line |
---|---|---|---|
Method edu.drexel.cms.service.service.CmsService$6.search() uses Collection.toArray() with zero-length array argument | PERFORMANCE | ITA_INEFFICIENT_TO_ARRAY | 193 |
Bug | Category | Details | Line |
---|---|---|---|
Method edu.drexel.cms.service.service.CmsService$7.search() uses Collection.toArray() with zero-length array argument | PERFORMANCE | ITA_INEFFICIENT_TO_ARRAY | 217 |
Bug | Category | Details | Line |
---|---|---|---|
Method edu.drexel.cms.service.service.CmsService$8.search() uses Collection.toArray() with zero-length array argument | PERFORMANCE | ITA_INEFFICIENT_TO_ARRAY | 241 |
Bug | Category | Details | Line |
---|---|---|---|
Method edu.drexel.cms.service.service.CmsServiceUtils.toConferenceElement(Conference) uses Collection.toArray() with zero-length array argument | PERFORMANCE | ITA_INEFFICIENT_TO_ARRAY | 56 |
Bug | Category | Details | Line |
---|---|---|---|
edu.drexel.cms.service.service.MockCmsService.SUCCESS isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 28 |
edu.drexel.cms.service.service.MockCmsService.FAILURE isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 30 |
Bug | Category | Details | Line |
---|---|---|---|
edu.drexel.cmsDb.datamodel.remote.input.AttachmentType.getContent() may expose internal representation by returning AttachmentType._content | MALICIOUS_CODE | EI_EXPOSE_REP | 21 |
edu.drexel.cmsDb.datamodel.remote.input.AttachmentType.AttachmentType(String, String, byte[]) may expose internal representation by storing an externally mutable object into AttachmentType._content | MALICIOUS_CODE | EI_EXPOSE_REP2 | 17 |
edu.drexel.cmsDb.datamodel.remote.input.AttachmentType.setContent(byte[]) may expose internal representation by storing an externally mutable object into AttachmentType._content | MALICIOUS_CODE | EI_EXPOSE_REP2 | 24 |
Bug | Category | Details | Line |
---|---|---|---|
edu.drexel.cmsDb.datamodel.remote.input.RemoteConference.getEditorUserNames() may expose internal representation by returning RemoteConference._editorUserNames | MALICIOUS_CODE | EI_EXPOSE_REP | 43 |
edu.drexel.cmsDb.datamodel.remote.input.RemoteConference.getEndDate() may expose internal representation by returning RemoteConference._endDate | MALICIOUS_CODE | EI_EXPOSE_REP | 63 |
edu.drexel.cmsDb.datamodel.remote.input.RemoteConference.getStartDate() may expose internal representation by returning RemoteConference._startDate | MALICIOUS_CODE | EI_EXPOSE_REP | 69 |
edu.drexel.cmsDb.datamodel.remote.input.RemoteConference.RemoteConference(String, String, String, String, Date, Date, String, String[]) may expose internal representation by storing an externally mutable object into RemoteConference._editorUserNames | MALICIOUS_CODE | EI_EXPOSE_REP2 | 34 |
edu.drexel.cmsDb.datamodel.remote.input.RemoteConference.RemoteConference(String, String, String, String, Date, Date, String, String[]) may expose internal representation by storing an externally mutable object into RemoteConference._endDate | MALICIOUS_CODE | EI_EXPOSE_REP2 | 32 |
edu.drexel.cmsDb.datamodel.remote.input.RemoteConference.RemoteConference(String, String, String, String, Date, Date, String, String[]) may expose internal representation by storing an externally mutable object into RemoteConference._startDate | MALICIOUS_CODE | EI_EXPOSE_REP2 | 31 |
edu.drexel.cmsDb.datamodel.remote.input.RemoteConference.setEditorUserNames(String[]) may expose internal representation by storing an externally mutable object into RemoteConference._editorUserNames | MALICIOUS_CODE | EI_EXPOSE_REP2 | 46 |
edu.drexel.cmsDb.datamodel.remote.input.RemoteConference.setEndDate(Date) may expose internal representation by storing an externally mutable object into RemoteConference._endDate | MALICIOUS_CODE | EI_EXPOSE_REP2 | 66 |
edu.drexel.cmsDb.datamodel.remote.input.RemoteConference.setStartDate(Date) may expose internal representation by storing an externally mutable object into RemoteConference._startDate | MALICIOUS_CODE | EI_EXPOSE_REP2 | 72 |
Bug | Category | Details | Line |
---|---|---|---|
edu.drexel.cmsDb.datamodel.remote.output.ConferenceElement.getEditorUserNames() may expose internal representation by returning ConferenceElement._editorUserNames | MALICIOUS_CODE | EI_EXPOSE_REP | 53 |
edu.drexel.cmsDb.datamodel.remote.output.ConferenceElement.getEndDate() may expose internal representation by returning ConferenceElement._endDate | MALICIOUS_CODE | EI_EXPOSE_REP | 59 |
edu.drexel.cmsDb.datamodel.remote.output.ConferenceElement.getStartDate() may expose internal representation by returning ConferenceElement._startDate | MALICIOUS_CODE | EI_EXPOSE_REP | 77 |
edu.drexel.cmsDb.datamodel.remote.output.ConferenceElement.ConferenceElement(long, String, String, String, String, Date, Date, String, String[]) may expose internal representation by storing an externally mutable object into ConferenceElement._endDate | MALICIOUS_CODE | EI_EXPOSE_REP2 | 42 |
edu.drexel.cmsDb.datamodel.remote.output.ConferenceElement.ConferenceElement(long, String, String, String, String, Date, Date, String, String[]) may expose internal representation by storing an externally mutable object into ConferenceElement._startDate | MALICIOUS_CODE | EI_EXPOSE_REP2 | 41 |
edu.drexel.cmsDb.datamodel.remote.output.ConferenceElement.setEditorUserNames(String[]) may expose internal representation by storing an externally mutable object into ConferenceElement._editorUserNames | MALICIOUS_CODE | EI_EXPOSE_REP2 | 56 |
edu.drexel.cmsDb.datamodel.remote.output.ConferenceElement.setEndDate(Date) may expose internal representation by storing an externally mutable object into ConferenceElement._endDate | MALICIOUS_CODE | EI_EXPOSE_REP2 | 62 |
edu.drexel.cmsDb.datamodel.remote.output.ConferenceElement.setStartDate(Date) may expose internal representation by storing an externally mutable object into ConferenceElement._startDate | MALICIOUS_CODE | EI_EXPOSE_REP2 | 80 |
Bug | Category | Details | Line |
---|---|---|---|
edu.drexel.cmsDb.datamodel.remote.output.DownloadPaperElement.getLastModifDate() may expose internal representation by returning DownloadPaperElement._lastModifDate | MALICIOUS_CODE | EI_EXPOSE_REP | 23 |
edu.drexel.cmsDb.datamodel.remote.output.DownloadPaperElement.DownloadPaperElement(AttachmentType, Date) may expose internal representation by storing an externally mutable object into DownloadPaperElement._lastModifDate | MALICIOUS_CODE | EI_EXPOSE_REP2 | 20 |
edu.drexel.cmsDb.datamodel.remote.output.DownloadPaperElement.setLastModifDate(Date) may expose internal representation by storing an externally mutable object into DownloadPaperElement._lastModifDate | MALICIOUS_CODE | EI_EXPOSE_REP2 | 26 |
Bug | Category | Details | Line |
---|---|---|---|
edu.drexel.cmsDb.datamodel.remote.output.PaperElement.getLastModifiedDate() may expose internal representation by returning PaperElement._lastModifiedDate | MALICIOUS_CODE | EI_EXPOSE_REP | 71 |
edu.drexel.cmsDb.datamodel.remote.output.PaperElement.setLastModifiedDate(Date) may expose internal representation by storing an externally mutable object into PaperElement._lastModifiedDate | MALICIOUS_CODE | EI_EXPOSE_REP2 | 74 |